Skip to content

fix(compiler): skip if guard when condition is empty after modifiers #12321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

fix(compiler): skip if guard when condition is empty after modifiers #12321

wants to merge 3 commits into from

Conversation

yuwu9145
Copy link

@yuwu9145 yuwu9145 commented Oct 11, 2021 •
edited
Loading

fix #12319

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@yuwu9145 yuwu9145 marked this pull request as ready for review October 11, 2021 23:25
@yuwu9145 yuwu9145 changed the title fix(compiler): do not add if guard when condition is empty fix #12319: Do not add if guard when condition is empty Oct 11, 2021
@yuwu9145 yuwu9145 changed the title fix #12319: Do not add if guard when condition is empty fix #12319: Do not generate if guard when condition is empty Oct 12, 2021
posva
posva requested changes Oct 12, 2021
View reviewed changes
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test?

@posva posva changed the title fix #12319: Do not generate if guard when condition is empty fix(compiler): skip if guard when condition is empty after modifiers Oct 12, 2021
@yuwu9145
Copy link
Author

@posva test is added

posva
posva approved these changes Oct 12, 2021
View reviewed changes
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@posva posva posva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.exact modifier : Failed to generate render function
2 participants
@yuwu9145 @posva